openid template cleanup

[GoogleCodeExporter]

Since the switch to new openid app, we need to address the following:

A bunch of openid URLs are hardcoded in account/login.html,
account/base.html and site_base.html

Also, the Open ID association page isn't styled properly.

Original issue reported on code.google.com by jtau...@gmail.com on 23 Nov 2008 at 7:32

[GoogleCodeExporter]

Yes, I had to hard code the URLs because of the approach django-openid takes 
with URL routing. It is similiar to 
a ModelAdmin where it is class based around the views and deals with URL 
routing internally and not with a 
URLconf. I totally agree this should be fixed, but isn't a Pinax issue at this 
point.

django-openid also doesn't work how it use to with associations so I had to 
improvise on the page since it was 
slightly different. I agree it should be fixed up though.

Original comment by bros...@gmail.com on 23 Nov 2008 at 7:43

[GoogleCodeExporter]

Even though the do_* methods in Consumer classes aren't reverse()able, making 
their
names necessarily hardcoded, the first part of the URL (currently ^/openid/) 
can be
made reversable by specifying a name for the URL. I've attached a patch to do 
this
for basic_project.

This is necessary to successfully use OpenID with Pinax when deployed at a URL 
other
than a domain root. It doesn't fix the hardcoding of the method names, but it 
makes
more of Pinax work out-of-box when not at a domain root.

The only thing I'm not real sure about is the naming convention for Pinax's URL
patterns; I've used 'pinax-openid-root' in the patch.

Original comment by akgo...@gmail.com on 30 Nov 2008 at 12:52

Attachments:

• pinax_openid_root_basic_project.diff

[GoogleCodeExporter]

And here's an untested patch for complete_project. I just munged the previous 
patch,
applied to the complete_project, fixed the one reject, and rediffed - but grep
doesn't seem to think it's missing any hardcoded /openid/s.

Original comment by akgo...@gmail.com on 30 Nov 2008 at 1:00

Attachments:

• pinax_openid_root_complete_project.diff

[GoogleCodeExporter]

Somewhat related patch attached; hardcoding of a couple URLs in
templates/django_openid/register.html, when URL pattern names are available for 
each.
This occurs in both basic_project and complete_project. There are many more 
hardcoded
URLs in complete_project, but grep tells me basic_project should be about done.

Original comment by akgo...@gmail.com on 30 Nov 2008 at 8:19

Attachments:

• openid-register-hardcoded-urls.diff

[GoogleCodeExporter]

akgomaa, That is a reasonable change to do in the mean time. I will take a look 
at the patch. There should be 
hardcoded URLs in both complete_project and basic_project as they both include 
OpenID support. They both 
have their own account and django_openid templates.

Original comment by bros...@gmail.com on 1 Dec 2008 at 5:20

[GoogleCodeExporter]

Original comment by pyDanny on 13 Mar 2009 at 4:03

• Added labels: Milestone-0.7

[GoogleCodeExporter]

Original comment by pyDanny on 31 Mar 2009 at 4:15

• Changed state: MovedToCpc