andreisergiu98 / arc-flatabulous-theme

Arc theme with Flatabulous window controls.
GNU General Public License v3.0
611 stars 42 forks source link

Doesn't build with libsass 3.6.3 #45

Open mrjavum opened 4 years ago

mrjavum commented 4 years ago

I think the problem is the same: libsass 3.6.3 do not support any more compound selector

Progi1984 commented 4 years ago

Same problem here

goulvenclech commented 4 years ago

Same problem here 😰

insign commented 4 years ago

Same problem here

ChrisLauinger77 commented 4 years ago

Same here - debian bullseye/sid

nicbet commented 4 years ago

My favourite theme hands-down! Was very sad when I couldn't build it on Ubuntu 20.04 with sassc 3.6.3. For what it's worth, was able to successfully build and activate in Ubuntu 20.04 with these steps:

#!/bin/bash

# Download sassc and dependencies from Bionic
wget http://launchpadlibrarian.net/365856925/multiarch-support_2.27-3ubuntu1_amd64.deb
wget http://launchpadlibrarian.net/353281752/libsass0_3.4.8-1_amd64.deb
wget http://launchpadlibrarian.net/344203197/sassc_3.4.5-1_amd64.deb

# Install sassc and dependencies from Bionic
sudo dpkg -i multiarch-support_2.27-3ubuntu1_amd64.deb
sudo dpkg -i libsass0_3.4.8-1_amd64.deb
sudo dpkg -i sassc_3.4.5-1_amd64.deb

# Install theme build-time dependencies
sudo apt install -y autoconf automake git optipng inkscape gnome-shell libgtk-3-dev gnome-themes-extra gtk2-engines-murrine

# Clone theme from Github and build
git clone https://github.com/andreisergiu98/arc-flatabulous-theme --depth 1 && cd arc-flatabulous-theme
./autogen.sh --prefix=/usr
sudo make install

# Clean up old sassc
sudo dpkg -r sassc
sudo dpkg -r libsass0
sudo dpkg -r multiarch-support

Not ideal, but hey - at least a stop gap until we get the upstream changes to common.scss and application.scss in.

insign commented 4 years ago

Thank you @nicbet worked fine.

Briffou commented 4 years ago

I had no problem building the theme with libsass 3.6.4.

Note: But I had a problem with Inkscape (1.0rc1 09960d6f05, 2020-04-09), had to change export-png to export-filename in Makefiles (cf https://gitlab.com/inkscape/inkscape/-/issues/516)

staniond commented 4 years ago

I had no problem building the theme with libsass 3.6.4.

Note: But I had a problem with Inkscape (1.0rc1 09960d6f05, 2020-04-09), had to change export-png to export-filename in Makefiles (cf https://gitlab.com/inkscape/inkscape/-/issues/516)

Had this exact same issue (with export-png option), maybe different issue should be made for this? Still, after resolving that, I could not build with libsass 3.6.3.

Note: If someone is having the same issue with export-png, this simple command will solve it find . -name 'Makefile' | xargs sed '-i' 's/--export-png/--export-filename/g'

tliron commented 4 years ago

I hope this issue can be addressed! I am the maintainer of the install-gnome-themes and I keep get people opening issues regarding this particular theme due to this particular error.

I would submit a PR myself, but I'm not sure what the right fix would be (how to not use @compound).

Briffou commented 4 years ago

Not sure if this issue is directly related to this theme (although it would also be a good thing to update the "origin" of this theme, from https://github.com/arc-design/arc-theme to https://github.com/jnsh/arc-theme for instance). But as I said I had no problem building this theme with libsass 3.6.4 and as you can see in the release note of libsass, version 3.6.4 fix regressions introduced in previous version.

andreisergiu98 commented 4 years ago

@Briffou I agree. I will try to rebase on jnsh's fork, it seems he already removed compound selectors, so it should solve this issue and maybe others.

davidnash commented 4 years ago

I'm getting this issue too. I get lots of "Compound selectors may not longer be extended" messages, and then eventually:

make[3]: *** [Makefile:554: gtk.css] Killed
make[3]: Leaving directory '/home/david/arc-flatabulous-theme/common/gtk-3.0/3.20'
make[2]: *** [Makefile:429: install-recursive] Error 1
make[2]: Leaving directory '/home/david/arc-flatabulous-theme/common/gtk-3.0'
make[1]: *** [Makefile:436: install-recursive] Error 1
make[1]: Leaving directory '/home/david/arc-flatabulous-theme/common'
make: *** [Makefile:361: install-recursive] Error 1
Briffou commented 4 years ago

@andreisergiu98 It should work fine, I've done it recently (only for gtk 3.24 by laziness :disappointed: ), you can look at this branch https://github.com/Briffou/arc-theme/tree/arc-flatabulous (which also have a commit with personal changes, so it's not "pure" arc-theme).

nathan818fr commented 3 years ago

A temporary workaround is to compile and use sassc v3.5.0. I advise you not to install packages (.deb/.rpm) intended for other or older distributions, they could pollute your current installation (eg. by replacing recent versions of these packages).

Then set the SASSC environment variable to this new sassc binary before running autogen:

cd arc-flatabulous-theme
export SASSC="/path/to/sass-build/sassc/bin/sassc"
./autogen.sh
make