search

andreiw / lampone

wip 3/4 stuff
14 stars 1 forks source link

Patches to the RP4 Build script #1

Closed ehem closed 4 years ago

ehem commented 5 years ago

Things I was noticing during attempts to build. Due to the way the lampone_build.sh script works, it will retrieve all branches and all tags from your mirrors of the EDK2 repositories. Due to the size of those repositories those branches mean a fair bit of bandwidth and disk space. I've also split the repository settings into a distinct file, so if the know okay EDK2 commit changes that is easier.

If one already has a cross-compiling GCC installed, one might want to use the already installed local cross-GCC. Though now that I think about it, I recall some issues of differing compiler versions causing some issues (erk).

andreiw commented 4 years ago

Thanks this is good stuff. I'll have to manually merge these, though, since I've made some changes.

ehem commented 4 years ago

Having some interesting times rebasing onto your head and identifying other bits.

set -e at times feels a bit hazardous, but the concern is you really want the build to fail as early as possible (since that means less waiting for the computer). Plus you don't want to give the impression it completed successfully when it didn't.

This switches from @ardbiesheuvel's branch of EDK2 to the @pftf branch. I suspect you would do this yourself in the not too distant future unless there is something I'm unaware of lurking in the pftf branch...

I would like to use /bin/sh instead of /bin/bash (bash is a good interactive shell, but is distinctly slow for scripts; /bin/sh is less featureful, but often significantly faster), but I suspect the edk2/edksetup.sh script requires bash (Korne shell is better for advanced scripts).

ehem commented 4 years ago

I've been having an interesting time testing, testing and more testing...

Bugs show up and need fixing, so new commits...

ehem commented 4 years ago

I'm left pondering the ideas of adding an option for doing git clean -fdx in the repositories, and adding the option not to update the repositories from GitHub (less network bandwidth, and EDK2 doesn't get that many updates).

andreiw commented 4 years ago

Thanks for your fixes. I really like what you've done to this. I did a bit of cleanup as it didn't work for me for w/e reason. I think you missed a bit of testing with dirty repos.