::get() can fetch 512 bytes at most

andreiz / php-zookeeper

A PHP extension for interfacing with Apache ZooKeeper

Other

449 stars 215 forks source link

Open hejin opened 12 years ago

hejin commented 12 years ago

Hi guys,

I found there is the hard-coded limitation in the ::get() function.

I have some simple code to fix it, and the idea is.

put the buffer to be static and big enough (say 1MB, align with the zk java community convention)
1st read to get node dataLength, 2nd read to fetch them all.

Of coz it should only work in single PHP thread, and to make it work with malloc/free is not hard.

Thanks, Jeff

mkoppanen commented 12 years ago

i can take a look at this later. Are you cool with that andrei?

mkoppanen commented 12 years ago