search

andreiz / php-zookeeper

A PHP extension for interfacing with Apache ZooKeeper
Other
449 stars 215 forks source link

PHP7 support #68

Closed jbboehr closed 6 years ago

asaarashi commented 8 years ago

Hi, @jbboehr Does it mean if this pull request is accepted, this extension would be able to work on PHP7?

jbboehr commented 8 years ago

@thrieu This PR adds support for PHP 7.0 while maintaining PHP 5.x support, so PHP 5.3 - 5.6 and 7.0. https://travis-ci.org/andreiz/php-zookeeper/builds/101712706

Babacooll commented 8 years ago

This is so nice, do you think this could be merged soon ?

asaarashi commented 8 years ago

@jbboehr Great, thank you. I am looking forward to it.

Babacooll commented 8 years ago

@thrieu Hi, do you have any idea when you can merge it ?

asaarashi commented 8 years ago

@Babacooll I've compiled @jbboehr 's php7 branch and created several simple test cases..

xjewer commented 8 years ago

@Babacooll I've compiled @jbboehr 's php7 branch and created several simple test cases..

and so, what is result @thrieu?

asaarashi commented 8 years ago

@xjewer No problem for now. I use it work with a Kafka library.

jbboehr commented 8 years ago

@xjewer I'm getting a leak when that patch is applied:

[Mon Feb 22 14:47:39 2016]  Script:  '~/php-zookeeper/tests/retrieve_node_with_maxsize_param.php'
/tmp/php-build/source/7.0.1/Zend/zend_string.h(121) :  Freeing 0x2AE16F801740 (32 bytes), script=/home/rin/Code/php-zookeeper/tests/retrieve_node_with_maxsize_param.php

Should be fixed in d39f534

xjewer commented 8 years ago

:ok_hand:

jbboehr commented 8 years ago

@andreiz It might be nice to get the PHP7 support into PECL. Does the PR look alright to you?

pramodpatilolx commented 8 years ago

@andreiz It would be nice if you can review the PR and create a tag for php7 support.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+29.06%) to 78.363% when pulling 131950ddb83310afb51269db6539d36c2daffe2e on jbboehr:php7 into 9d6c822837de7bc600872b127d857a97eba8d369 on andreiz:master.

mweibel commented 7 years ago

what's the status here? :)

coveralls commented 7 years ago

Coverage Status

Coverage increased (+28.4%) to 77.663% when pulling 781e538018d1e1a717a7e4b1b8794e89cc372e60 on jbboehr:php7 into 9d6c822837de7bc600872b127d857a97eba8d369 on andreiz:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+28.4%) to 77.663% when pulling 781e538018d1e1a717a7e4b1b8794e89cc372e60 on jbboehr:php7 into 9d6c822837de7bc600872b127d857a97eba8d369 on andreiz:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+28.4%) to 77.663% when pulling 781e538018d1e1a717a7e4b1b8794e89cc372e60 on jbboehr:php7 into 9d6c822837de7bc600872b127d857a97eba8d369 on andreiz:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+29.07%) to 78.371% when pulling fe0d0af5cee8890367e02b69dee8e7c45c91fa6a on jbboehr:php7 into 9d6c822837de7bc600872b127d857a97eba8d369 on andreiz:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+29.07%) to 78.371% when pulling fe0d0af5cee8890367e02b69dee8e7c45c91fa6a on jbboehr:php7 into 9d6c822837de7bc600872b127d857a97eba8d369 on andreiz:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+29.07%) to 78.371% when pulling fe0d0af5cee8890367e02b69dee8e7c45c91fa6a on jbboehr:php7 into 9d6c822837de7bc600872b127d857a97eba8d369 on andreiz:master.

richRemer commented 6 years ago

2 years? Can I just assume this project has been abandoned?

jbboehr commented 6 years ago

@richRemer We've been maintaining it here: https://github.com/php-zookeeper/php-zookeeper