andreiz / php-zookeeper

A PHP extension for interfacing with Apache ZooKeeper
Other
449 stars 215 forks source link

Does not build with php 7.1 #82

Closed paulm17 closed 7 years ago

paulm17 commented 7 years ago

Does not build with 7.1

First error:

/root/php-zookeeper-master/php_zookeeper.c:38:40: fatal error: ext/standard/php_smart_str.h: No such file or directory
#include <ext/standard/php_smart_str.h>
                                    ^
compilation terminated.
make: *** [php_zookeeper.lo] Error 1

Easy to fix, because php_smart_str -> php_smart_string with 7.1

Another error:

/root/php-zookeeper-master/php_zookeeper.c: In function 'zm_startup_zookeeper':
/root/php-zookeeper-master/php_zookeeper.c:1217:30: warning: assignment from incompatible pointer type [enabled by default]
zookeeper_ce->create_object = php_zk_new;
                          ^
make: *** [php_zookeeper.lo] Error 1
Timandes commented 7 years ago

Could you please provide the version of your php-zookeeper?

paulm17 commented 7 years ago

I'm using master from andreiz/php-zookeeper.

Master from Timandes/libzookeeper, compiles with no errors.

Also, pecl install zookeeper-0.3.2, compiles with no errors also.

Which version is best to use? I am confused.

Thanks

Timandes commented 7 years ago

Try pecl/zookeeper. Enjoy it.

paulm17 commented 7 years ago

Many thanks!