andrejilderda / joplin-macos-native-theme

Native looking macOS theme for note taking app Joplin
MIT License
279 stars 14 forks source link

Some buttons are not displayed in the Rich Text Editor #112

Closed nelizondo227 closed 8 months ago

nelizondo227 commented 8 months ago

Joplin 2.13.9 (prod, darwin) macOS theme: 1.3.13

Screenshot 2023-12-14 at 12 18 30 PM

The buttons work, but the icon is not displayed. Screenshot 2023-12-14 at 12 20 32 PM

Thanks

kristophercrawford commented 8 months ago

I have a quick and dirty patch for this:

@@ -434,22 +454,37 @@
     button:nth-child(1):before {
       content: "H1";
     }
+
     button:nth-child(2):before {
       content: "H2";
     }
+
     button:nth-child(3):before {
       content: "H3";
     }
-    button:nth-child(4):before {
+  }
+
+  .tox-toolbar__group:nth-child(5) {
+    button:nth-child(1):before {
       @include icon(minus);
     }
-    button:nth-child(5):before {
+  }
+
+  .tox-toolbar__group:nth-child(6) {
+
+    button:nth-child(1):before {
       @include icon(text-quote);
     }
-    button:nth-child(6):before {
+  }
+
+  .tox-toolbar__group:nth-child(7) {
+    button:nth-child(1):before {
       @include icon(tablecells-badge-ellipsis);
     }
-    button:nth-child(7):before {
+  }
+
+  .tox-toolbar__group:nth-child(8) {
+    button:nth-child(1):before {
       @include icon(clock);
     }
   }

image

But I would like to wait and get some direction on #110 and #109 to see if I am merging these changes in correctly.

andrejilderda commented 8 months ago

Thanks @kristophercrawford , that was really helpful!