search

andrejilderda / joplin-macos-native-theme

Native looking macOS theme for note taking app Joplin
MIT License
286 stars 14 forks source link

Add CodeMirror One Dark theme #113

Closed kristophercrawford closed 9 months ago

kristophercrawford commented 10 months ago

I'd like to try tackling this request: https://discourse.joplinapp.org/t/plugin-macos-theme-for-joplin/18934/114

Could you provide the steps needed to incorporate the theme? I believe the source is this: https://github.com/codemirror/theme-one-dark

andrejilderda commented 10 months ago

Hi @kristophercrawford , yes I think you should be able to transform this TypeScript file into a CSS-file like the ones in this folder. In order for it to show up as an option in the Joplin plugin settings it should be added to editorMarkdownThemeLught or editorMarkdownThemeDark here.

mikicvi commented 9 months ago

I would absolutely die out of happiness to see this colour scheme added to this project! My absolute favourite one and I am dreading not having it here.

mikicvi commented 9 months ago

Is there a specific version of Node that is used for development of this project? On npm run dist I seem to be getting opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ], library: 'digital envelope routines', reason: 'unsupported', code: 'ERR_OSSL_EVP_UNSUPPORTED' }

I am getting exactly the same issue on both Windows and Fedora.

andrejilderda commented 9 months ago

@mikicvi Yes, I think it's v16 as I need to update some dependencies. 😅

kristophercrawford commented 9 months ago

What I am finding is that the one-dark theme from here: https://github.com/codemirror/theme-one-dark/blob/main/src/one-dark.ts doesn't match the one-dark theme on HedgeDoc website. I copied the CSS from the HedgeDoc site and applied it to come up with this:

image

Using the seemingly official style I end up with the following:

image

So that leaves the question of should the one-dark theme be the seemingly official one or the HedgeDoc implementation of it?

andrejilderda commented 9 months ago

@kristophercrawford I personally prefer the second one since it blends in better with the rest of the theme. I think that is also the one @mikicvi took as a base and implemented in #119. That PR I just merged so should be available in 30 mins when the Joplin bot picks up the change. I assume this issue is solved, so closing this for now. Thanks again @mikicvi!