andrejilderda / joplin-macos-native-theme

Native looking macOS theme for note taking app Joplin
MIT License
290 stars 14 forks source link

Notebook (folder) icons disapeared after update to v1.5.3 #137

Closed iAweX closed 6 months ago

iAweX commented 6 months ago

OS: Debian 12 (bookworm) Jopplin v2.14.20 macOS theme v1.5.3

Notebook (folder) icons disapeared after update to v1.5.3 from joplin repo

image

andrejilderda commented 6 months ago

Hmm... interesting. Do you have the icon family set to Phosphor?

image
iAweX commented 6 months ago

I have both fonts installed and tried to switch between them, but with no success. Before update everything worked fine with both fonts.

andrejilderda commented 6 months ago

@iAweX Hopefully this is fixed with v.1.5.6. Can you confirm if that's the case?

You should not have to install Phosphor icons by the way, since it comes with the theme.

iAweX commented 6 months ago

Unfortunately PR 139 didn't fixed missed icons. And icons missed when trying to use both fonts.

andrejilderda commented 6 months ago

I see that you're using an older version of Joplin. Have you tried upgrading to v3?

iAweX commented 6 months ago

As I found out v3 is pre-release. I am trying to use stable releases. Also I use flatpak version, that offers only stable version v2.14.20

andrejilderda commented 6 months ago

Ah got it! Wasn't aware I was using a pre-release. 😅 I just downgraded and can reproduce the issue. Hope to have a fix soon.

iAweX commented 6 months ago

@andrejilderda, thanks for your macos theme and help. It's Great!

andrejilderda commented 6 months ago

@iAweX I put up a fix in v1.5.7. Can you check if this solves the issue for you?

iAweX commented 6 months ago

@iAweX I put up a fix in v1.5.7. Can you check if this solves the issue for you?

Issue solved. Thanks!