search

andrejilderda / joplin-macos-native-theme

Native looking macOS theme for note taking app Joplin
MIT License
281 stars 14 forks source link

Activated Theme slows down Joplin #48

Closed reaseno closed 2 years ago

reaseno commented 2 years ago

When I use the theme, the typed text takes some time between typing on the keyboard and appearing on the screen until it becomes visible, which makes typing a bit annoying. The positioning of the cursor is also delayed.

andrejilderda commented 2 years ago

Hi @reaseno, are you sure this is because of the theme? It doesn't do much except for injecting styles. Don't you notice this when the theme is disabled?

reaseno commented 2 years ago

Ah right, I wanted to write you that I'm analyzing the problem, since it seems to happen also when I paste your CSS manually. But I don't think it's because of the CSS itself. So it's probably not your module.

But at least Joplin starts much faster when the module is disabled and your CSS is inserted via userchrome.css. Wouldn't it be better if the module did it that way too?

andrejilderda commented 2 years ago

@reaseno I've made this change in v.1.2.17 of the plugin and I'm curious if you notice any difference.

andrejilderda commented 2 years ago

Fyi, it removes the loading of an svg-file which was 5 mb. big. 😅

reaseno commented 2 years ago

Sorry, I forgot to update you on my problem. Because recently I found the cause. This is that Joplin's preview (Markdown/PDF/WYSIWG renderer) is always active no matter if you have it open. For smaller notes this is not a problem, but for notes with more than 2000 lines there is always a pause when the renderer updates its view.

The solution was the plugin "Disable PDF". This deactivates the renderer. Not to be confused with the option > Markdown > "Enable PDF viewer" which seems to be intended for PDF attachments.

And as for your update, yes, Joplin starts much faster for me now 👍

andrejilderda commented 2 years ago

@reaseno Ah great to hear, closing this!