search

andrejilderda / joplin-macos-native-theme

Native looking macOS theme for note taking app Joplin
MIT License
290 stars 14 forks source link

UI Issue on Note List Sidebar #57

Closed hpradogu closed 2 years ago

hpradogu commented 2 years ago

Hello!

thanks for creating this theme! I just downloaded it today, and absolutely love it.

I did notice a minor issue with the UI after installing, however.

Joplin version 2.7.12 macOS 12.2.1

You can see that the search and the sorting (and the other icons) are now squished together in the corner.

Screen Shot 2022-02-17 at 14 00 15
andrejilderda commented 2 years ago

Hi @hpradogu , this only happens if you have the sidebar set to a very small width, don't you? In that case, the solution would be to increase it. 😉

hpradogu commented 2 years ago

Original Issue

Yes, you are correct. However, I'm running Joplin on my iPad as my second monitor, so my resolution isn't that great (so things generally need to be smaller).

When I run custom CSS styling, I don't have this particular issue, and it seems like the stock Dark Joplin theme handles it decently.

See the behavior with custom CSS styling (there's a minimum width set: https://user-images.githubusercontent.com/12103688/155187243-d5b569e3-84a5-4fb4-a843-3f0a90db23aa.mov

Here's the stock Joplin dark theme behavior : https://user-images.githubusercontent.com/12103688/155188046-b6562c03-fcac-4648-9230-859055a7a44e.mov

Here's the behavior with the macOS theme: https://user-images.githubusercontent.com/12103688/155187958-8b8c834f-a43c-4914-973c-25212f8fbda4.mov

New Issue

I'm having another (different issue) related to UI. Not sure if you've seen this:

Screen Shot 2022-02-22 at 09 33 57

All the icons are now just squares. All other plugins are turned off.

andrejilderda commented 2 years ago

Thanks for the detailed report! I've just pushed a change which should fix your issue.

Regarding the icons, do you maybe have it set to macOS native (SF Pro) in the plugin settings, while not having SF Pro installed? See the installation instructions here.

screenshot 2022-02-25 at 21 22

andrejilderda commented 2 years ago

@hpradogu Here's a screencap :)

https://user-images.githubusercontent.com/487182/155799790-920d2738-8ece-406c-bbf1-0eb1f1259fa2.mov

hpradogu commented 2 years ago

Very nice!! Thanks so much. I'll test it out again and confirm on my end.

Regarding the icons, I'll have to check that out.

Thanks again for your prompt help with this :)