search

andrejilderda / joplin-macos-native-theme

Native looking macOS theme for note taking app Joplin
MIT License
290 stars 14 forks source link

Problems with markdown rendering on MacOS #72

Closed pschopen closed 1 year ago

pschopen commented 2 years ago

Since using the Mac Theme with Joplin I discovered some Problems with markdown rendering that don't show up using the original theme. See the video attached. Rendering is only correct after pressing the button and switching between the modes. And even then the correct rendering is still slightly delayed.

https://user-images.githubusercontent.com/65334274/168908514-b4c8c75b-5ae8-4240-89cd-db83f6a59a41.mov

ScriptInfra commented 2 years ago

Good catch on this, @pschopen! I am seeing this issue as well running Joplin on Linux. I knew about this issue but assumed it was an issue with the core Joplin app since I exclusively use the MacOS theme.

pschopen commented 2 years ago

My impression was, that it has something to do with the styling that the theme does to the markdown text. A solution could be to offer only the interface styling and have markdown styling only as an option within extension settings?

andrejilderda commented 2 years ago

Hi @pschopen , can you check if this is solved after upgrading to the latest version? (1.3.5)

ScriptInfra commented 2 years ago

Hi @pschopen , can you check if this is solved after upgrading to the latest version? (1.3.5)

@andrejilderda - Unfortunately I believe this is still an issue:

Screenshot before switching editor modes: Screenshot 2022-12-01 at 11 36 06 AM

Screenshot after switching editor modes: Screenshot 2022-12-01 at 11 36 15 AM

andrejilderda commented 1 year ago

Thanks for checking this @pschopen & @ScriptInfra . With the newest version (v1.3.9) this should be fixed. Can you confirm if that is the case? If not, feel free to reopen this issue.

ScriptInfra commented 1 year ago

@andrejilderda - I am no longer able to reproduce this issue. Thanks so much for fixing this! What a huge quality improvement! I'll report back if I see any issues after further use.

andrejilderda commented 1 year ago

Great! 🎉

pschopen commented 1 year ago

@andrejilderda - I am no longer able to reproduce this issue. Thanks so much for fixing this! What a huge quality improvement! I'll report back if I see any issues after further use.

Same for me. Thank you very much; it makes a big difference!