andrejilderda / joplin-macos-native-theme

Native looking macOS theme for note taking app Joplin
MIT License
289 stars 14 forks source link

Text selections in Dark Mode inside code blocks are invisible #80

Open deftdawg opened 2 years ago

deftdawg commented 2 years ago

When selecting text inside code blocks (either `` or), the selection is not highlighted or not visible. This issue exists in 1.3.3. Outside of code boxes text is highlighted as expected, it maybe that the selection highlight colour is the same colour as the code box background... whatever the case, it's impossible to tell if one has selected a whole block, a single line or part of a line.

Dark mode: image

Light mode (good):

image

andrejilderda commented 1 year ago

Hi @deftdawg , can you please share which Markdown editor dark you have selected under Settings › macOS theme? I can't reproduce it with 3024-night or base16-dark.

image
jicheu commented 1 year ago

I can confirm the same issue with base16-dark With 3024-night I could not really see either but blackboard made the trick

For future reference he's what I see with 3024-dark :

kristophercrawford commented 10 months ago

For what it's worth, I was having problems with highlighted text being hard to read as well. The following css is from my userchrome.css file and sets highlighted text to be orange:

/* Overriding text highlight color */
.CodeMirror.CodeMirror.CodeMirror .CodeMirror-line::selection, .CodeMirror.CodeMirror.CodeMirror .CodeMirror-line > span::selection, .CodeMirror.CodeMirror.CodeMirror .CodeMirror-line > span > span::selection {
  background: #f63f05 !important;
}