andrejilderda / joplin-macos-native-theme

Native looking macOS theme for note taking app Joplin
MIT License
289 stars 14 forks source link

broken on 2.9.11 prerelease #83

Closed sdip15fa closed 1 year ago

sdip15fa commented 2 years ago

Hi there, after upgrading to 2.9.11 prerelease macos theme is now broken and would cause the joplin desktop app unable to render. (tested on 2.9.11 prerelease AND latest dev branch) Screenshot_20221028_213122-1

ScriptInfra commented 2 years ago

Which OS are you on? I was able to get Joplin version 2.9.11 working on macOS with the theme applied. You could also try reinstalling the theme if you haven't already.

sdip15fa commented 2 years ago

Which OS are you on? I was able to get Joplin version 2.9.11 working on macOS with the theme applied. You could also try reinstalling the theme if you haven't already.

arch linux

sdip15fa commented 2 years ago

@ScriptInfra you are right, it does work with a fresh install. But for some reason it wouldn't work for my install -- without macos theme it would work, and after installing macos theme it is broken. Probably I messed up with the settings.

sdip15fa commented 2 years ago

would you happen to know where the plugin settings are stored?

ScriptInfra commented 2 years ago

would you happen to know where the plugin settings are stored?

I'm afraid not. The only directories I am aware of that are related to plugins is /Users/username/.config./joplin-desktop/plugins and /Users/username/.config./joplin-desktop/cache

sdip15fa commented 2 years ago

Thanks @ScriptInfra, I have resolved it by deleting all macos theme entries in the settings table of database.sqlite.

andrejilderda commented 2 years ago

Good to hear things have been solved. Thanks for thinking along @ScriptInfra !

mikicvi commented 1 year ago

Hey, I'm having the same issue with the theme ever since 2.9.11, and it's the same for 2.9.12. I've tried the fix mentioned above, but its still the same.

Any other suggestions?

sdip15fa commented 1 year ago

Hey, I'm having the same issue with the theme ever since 2.9.11, and it's the same for 2.9.12.

I've tried the fix mentioned above, but its still the same.

Any other suggestions?

Same here, so I am still using 2.9.8. But I have noticed it would work if I disable all other plugins.

mikicvi commented 1 year ago

Hey, I'm having the same issue with the theme ever since 2.9.11, and it's the same for 2.9.12. I've tried the fix mentioned above, but its still the same. Any other suggestions?

Same here, so I am still using 2.9.8. But I have noticed disabling all other plugins it does work.

Unfortunately, that is the only plugin I use, since I suspected that other plugins were causing the issue, so I got rid of them since I never really used them anyway... I also tried various different built in themes, but to no avail, which is too bad, since this is my favourite theme for Joplin.

sdip15fa commented 1 year ago

Hey, I'm having the same issue with the theme ever since 2.9.11, and it's the same for 2.9.12.

I've tried the fix mentioned above, but its still the same.

Any other suggestions?

Same here, so I am still using 2.9.8. But I have noticed disabling all other plugins it does work.

Unfortunately, that is the only plugin I use, since I suspected that other plugins were causing the issue, so I got rid of them since I never really used them anyway...

I also tried various different built in themes, but to no avail, which is too bad, since this is my favourite theme for Joplin.

Did you try a clean install? That is removing everything in ~/.config/joplin-desktop/plugins

sdip15fa commented 1 year ago

or just test using a different HOME variable, i.e. HOME=~/Downloads joplin-desktop

sdip15fa commented 1 year ago

It did work for me if it’s a clean install. Did you get any errors? (I got none).

mikicvi commented 1 year ago

Tried wiping the .config directory. I restarted Joplin couple of times and so far so good.., I can report more during Sunday when I get more time.

Just a quick question - do you get this weird theme changing behaviour upon launching Joplin? It feels as if it goes back to default theme every time, and then the plugin theme is applied(happens within 1 sec window)...

sdip15fa commented 1 year ago

Tried wiping the .config directory. I restarted Joplin couple of times and so far so good.., I can report more during Sunday when I get more time.

Just a quick question - do you get this weird theme changing behaviour upon launching Joplin? It feels as if it goes back to default theme every time, and then the plugin theme is applied(happens within 1 sec window)...

yeah, this happens to me when it works

mikicvi commented 1 year ago

Tried wiping the .config directory. I restarted Joplin couple of times and so far so good.., I can report more during Sunday when I get more time. Just a quick question - do you get this weird theme changing behaviour upon launching Joplin? It feels as if it goes back to default theme every time, and then the plugin theme is applied(happens within 1 sec window)...

yeah, this happens to me when it works

Just FYI that only started happening with 2.9.11 and persists through 2.9.12, at least in my case.

sdip15fa commented 1 year ago

Tried wiping the .config directory. I restarted Joplin couple of times and so far so good.., I can report more during Sunday when I get more time. Just a quick question - do you get this weird theme changing behaviour upon launching Joplin? It feels as if it goes back to default theme every time, and then the plugin theme is applied(happens within 1 sec window)...

yeah, this happens to me when it works

Just FYI that only started happening with 2.9.11 and persists through 2.9.12, at least in my case.

same here. I think it was after the 2.9.8 release that I encountered this.

andrejilderda commented 1 year ago

Hmmm... thanks everyone for testing and looking into this. For me everything is working fine on 2.9.12 and I can't reproduce the issue. Maybe because I updated from an older stable version directly to 2.9.12?

That being said, is anyone still experiencing problems?

Btw. I've also just commented here: https://github.com/laurent22/joplin/issues/7051#issuecomment-1304808586

sdip15fa commented 1 year ago

Hmmm... thanks everyone for testing and looking into this. For me everything is working fine on 2.9.12 and I can't reproduce the issue. Maybe because I updated from an older stable version directly to 2.9.12?

That being said, is anyone still experiencing problems?

Btw. I've also just commented here: laurent22/joplin#7051 (comment)

Did you do all the steps for reproducing the issue? You must install some (a lot of) other plugins that it wouldn't work... Kinda weird

sdip15fa commented 1 year ago

Screenshot_20221107_205439

I think just installing these will do. And I can't locate which plugin is the problem after a lot of testing

andrejilderda commented 1 year ago

I just installed all those in your screenshot and it still works. :/ What issue are you facing? Still the blank page? In that case, can you show me what's displayed in the Elements tab in the web developer tools?

sdip15fa commented 1 year ago

Screenshot_20221107_211022 Nothing there!

andrejilderda commented 1 year ago

Hmm... so, just to be sure, everything works fine when the theme is uninstalled/disabled? I can't see how the theme is able to cause your issues, since I'm not doing anything too exciting technically. 😅

sdip15fa commented 1 year ago

Hmm... so, just to be sure, everything works fine when the theme is uninstalled/disabled? I can't see how the theme is able to cause your issues, since I'm not doing anything too exciting technically. sweat_smile

Yup, works as soon as I uninstall it (on my setup). On a fresh install it really is not broken.

sdip15fa commented 1 year ago

Oh, forgot to tell one of the plugins (enhancement) is my own fork

sdip15fa commented 1 year ago

And you are right, still not broken after installing those... emm...

sdip15fa commented 1 year ago

Ok, after some testing, it seems like with a same plugins set:

sdip15fa commented 1 year ago

Seems like it isn't so simple. After some configuration (sync target) it is broken again...

sdip15fa commented 1 year ago

So I ended up resolving the issue by removing a lot of plugins that didn't work with macos theme