search

andrejunges / vscode-handlebars

Handlebars for Visual Studio Code
https://marketplace.visualstudio.com/items/andrejunges.Handlebars
MIT License
18 stars 7 forks source link

Multi-line comments don't properly mute colors between open and close tags #7

Open delfuego opened 5 years ago

delfuego commented 5 years ago

For version 0.4.1 of the extension, when you use multi-line comment tags ({{!-- and --}}), and you have a Handlebars tag between the comment tags, the }} at the end of the tag causes the color muting to end on the comment.

Try to view a file with the following in it:

{{!--
This is a line with a {{handlebars.tag}} in it.
And then more stuff too.
--}}

At least for me, the visual color muting ends at the }} of the {{handlebars.tag}} tag.

delfuego commented 5 years ago

Of note, according to this, this was an issue in older versions of the daaain/Handlebars library but was fixed. It's unclear to me how much this extension relies on that library.

andrejunges commented 5 years ago

hey @delfuego I tried with the latest syntax definition file from https://github.com/daaain/Handlebars and it worked fine (on your example). So I created a PR and I can release a new version asap.. though I can't guarantee that won't break other functionalities.. I dont think so, but I've not been using ember for a while and I think it should be tested in a real project... Can you help me on it?

jeffdaley commented 1 year ago

@andrejunges How I can test your PR branch within VSCode? I wasn't able to find docs on that. Thanks!