Closed flighter18 closed 5 years ago
@sualko i checked out your fix:
commit b889e2da19ea30580c9e55f685fe8e7a98166b56 (HEAD)
Merge: 5cee070 331d1ef
Author: raphael.schib <raphael.schib@kara-network.ch>
Date: Fri Oct 11 17:15:34 2019 +0100
Merge commit '331d1ef4adeb4269893bb7bdc840fd0b2b1c6ec4' of https://github.com/andreknieriem/photobooth into HEAD
commit 331d1ef4adeb4269893bb7bdc840fd0b2b1c6ec4
Author: sualko <klaus@jsxc.org>
Date: Fri Oct 11 15:15:14 2019 +0200
fix gallery buttons on small screens
fix #116
but unfortunately it still not working
@flighter18 you need to run yarn build
again.
Once something is in master branch merged it's enough to git fetch origin && git checkout origin/master && yarn build
(you must have cloned from here)
If you've cloned from somewhere else, e.g. from my GitHub or your own fork add this repo as remote: git remote add andreknieriem https://github.com/andreknieriem/photobooth
Now replace origin
with andreknieriem
in above mentioned commands.
@andi34 I have done the following
sudo -u www-data -s
git remote add andreknieriem https://github.com/andreknieriem/photobooth
git fetch andreknieriem
git checkout andreknieriem/master
yarn build
exit
but the buttons dosen't work. Maybe i did a mistake with git?
If no error was visible and it was telling git checkout
was fine it should be ok. It'll tell you in terminal if it can not checkout because of uncommitted changes for example (in case you made some changes by hand in your source)
@andi34 no error was visible. so I think the button does still not work.
You can check git log
if latest commit hash matches the one here, should be 331d1ef4adeb4269893bb7bdc840fd0b2b1c6ec4
if you're not sure
@andi34 thank you for this hint.
[root@raspberrypi:/var/www/html# git log
commit 331d1ef4adeb4269893bb7bdc840fd0b2b1c6ec4 (HEAD, andreknieriem/master)
Author: sualko <klaus@jsxc.org>
Date: Fri Oct 11 15:15:14 2019 +0200]
So it matches.
You're able to test on Android? Only specific browser?
i do not have any android device but i tested it with 3 browser on ipad and iphone. none of them works.
Ok. Might be able to check in the morning on Android. Will have to setup my pi again as access point for it.
Quickly tested 😂 no issues on my phone , Android 9, Chrome browser, OnePlus 6.
I tested it now also on IOS 13. here it works too 🙈. So the problem is IOS 12
🥴 my ipad is to old for IOS13 😅 shit
https://forum.webflow.com/t/button-not-responding-in-safari-on-iphone/51418 Seems a known issue?
on click vs on touchstart?
If I open a pic in the gallery, the button in the right corner doesn't work except the close button. I uploaded a video: https://youtu.be/e3e1k_bvFxc