search

andreknieriem / simplelightbox

Touch-friendly image lightbox for mobile and desktop
https://simplelightbox.js.org
MIT License
1.11k stars 171 forks source link

Not working when using GET parameters. // Workaround 'fileExt' : false #237

Closed steiha closed 3 years ago

steiha commented 3 years ago

The gallery does not work when using GET parameters. Eg. if generating images dynamically.

I am not quite sure if I should consider this as a bug. As a workaround I could disable the file extension check via the options.

'fileExt' : false

But maybe this should be stated in the documentation.

As an example see a real use:

https://www.chordsheet.com/song/png/39?transpose=2

The images are generated dynamically using GET parameters.

https://www.chordsheet.com/song/39-1.png?transpose=2 https://www.chordsheet.com/song/39-2.png?transpose=2

I really love your gallery script, great job, thank you!

andreknieriem commented 3 years ago

Hi, that is exactly for what the option fileExt: false is ;) Thanks for your issue and for your feedback!

steiha commented 3 years ago

Ok, thank you.