search

andreldm / xfwm4-theme-generator

Creates xfwm4 themes from client side decorations.
GNU General Public License v2.0
23 stars 4 forks source link

Missing maximize-toggled-* icons. #4

Open matiasdelellis opened 2 years ago

matiasdelellis commented 2 years ago

These icons are used for the "restore" icon for maximized windows.

You can see a good example in Default-4.6.. 😉 Default-4.6 maximized window

In CSD it depends on the selected icon theme, and in particular the elementary-xfce theme (Now I'll report it there too.) doesn't differentiate both buttons either. but if we use the original elementary icon theme you can see how the icon is different and why it is important to have it.

CSD maximized with elementary icon theme

CSD normal with elementary icon theme

p.s.: Thanks for the project. I would love something like that that worked dynamically, but I'm really happy with the result. 😄 ❤️

matiasdelellis commented 2 years ago

p.s 2: Try to make the patch, it seems simple at first glance (Maximize and capture), But it is more difficult (Not so much, but I hope you solve it), since when you maximize the window, it seems that the GtkHeaderBar is destroyed and the buttons are created again.. 😞

andreldm commented 2 years ago

Hi @matiasdelellis, indeed, I never noticed this because Greybird (theme I use) seems to somehow override what is defined by the icon theme. I can confirm that with Adwaita it is possible to see different icons for the maximize button.

it seems simple at first glance (Maximize and capture), But it is more difficult (Not so much, but I hope you solve it), since when you maximize the window, it seems that the GtkHeaderBar is destroyed and the buttons are created again

Perhaps this can be solved by calling search_widgets again after maximizing (I would make it the last step before closing the window). Alternatively, the image of the maximize button can be changed from "window-maximize-symbolic" to "window-minimize-symbolic".

With this information would like to try to make a patch again? :wink: :pray:

p.s.: Thanks for the project. I would love something like that that worked dynamically, but I'm really happy with the result.

I'm glad you liked it, it is my attempt to minimize the visual inconsistencies between SSD x CSD and maybe quench a little bit the flame wars about CSD.

What do you mean by "work dynamically"? That it would regenerate themes automatically whenever the system theme/icon theme changes? If that's the case, fortunately the xfwm4 maintainer showed interest in supporting something that solves this problem, there is also a future request tracking this.