search

andrenatal / git-auto-updater

Git Auto updater
Other
1 stars 0 forks source link

Correct delay for times in the past - Issue #5 #6

Closed kdavis-mozilla closed 8 years ago

kdavis-mozilla commented 8 years ago

@Cwiiis @andrenatal Can you take a look

Cwiiis commented 8 years ago

This looks ok, but I think would be more logically expressed by altering minutes instead of delay? Something like minutes += 12 * 10? Not at a computer right now, so a little hard to check. Might be good to add a comment to say what's going on there while you're altering that area.

kdavis-mozilla commented 8 years ago

@Cwiiis Only adding the line

minutes += 12 * 10

would be incorrect.

The delay is too small by 12 hours. This subtracts 120 min from the delay instead of adding 12 hours.

Cwiiis commented 8 years ago

Actually, shouldn't it just be hours -= 24?

kdavis-mozilla commented 8 years ago

That would work too

Cwiiis commented 8 years ago

That would work and be correct :) Not sure why I subtracted only 12 in the first place... Could you change your pull request to do that?

kdavis-mozilla commented 8 years ago

Ok I'll change the pull request to do it that way.

kdavis-mozilla commented 8 years ago

@Cwiiis Changed