Closed kdavis-mozilla closed 8 years ago
This looks ok, but I think would be more logically expressed by altering minutes instead of delay? Something like minutes += 12 * 10? Not at a computer right now, so a little hard to check. Might be good to add a comment to say what's going on there while you're altering that area.
@Cwiiis Only adding the line
minutes += 12 * 10
would be incorrect.
The delay is too small by 12 hours. This subtracts 120 min from the delay instead of adding 12 hours.
Actually, shouldn't it just be hours -= 24?
That would work too
That would work and be correct :) Not sure why I subtracted only 12 in the first place... Could you change your pull request to do that?
Ok I'll change the pull request to do it that way.
@Cwiiis Changed
@Cwiiis @andrenatal Can you take a look