andrenatal / unimrcp

Automatically exported from code.google.com/p/unimrcp
Apache License 2.0
0 stars 0 forks source link

Core dump with large in-line grammars #52

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What version of the product is patch made on?

.070

Please use labels and text to provide additional information.

In file:

./libs/mrcp/message/src/mrcp_message.c

This is defined:

#define MRCP_MESSAGE_LENGTH_MAX_DIGITS_COUNT 4

I suggest that it be changed to:

#define MRCP_MESSAGE_LENGTH_MAX_DIGITS_COUNT 6

Why?  If you define a grammar in-line that is more than 9999 bytes in
length unimrcp clients will crash.

I have patched my code and have run in-line grammars which are almost 100K
in size.  It no longer core dumps.

Original issue reported on code.google.com by asackh...@gmail.com on 26 Oct 2009 at 11:55

GoogleCodeExporter commented 9 years ago
Thanks, I've applied the proposed change in r1229. Also message length 
generation
routine will not crash any more even if max digits are exceeded.

Original comment by achalo...@gmail.com on 27 Oct 2009 at 8:11

GoogleCodeExporter commented 9 years ago

Original comment by achalo...@gmail.com on 9 Jan 2010 at 6:48