Closed rizo closed 6 years ago
Thanks for the PR! I wouldn't mind renaming create
to make
, but isn't create
the most commonly used name for constructors in OCaml?
@andrenth Unfortunately the Stdlib is inconsistent with regards to constructor function naming so it's hard to say. Specifically the Array
, Bytes
and String
modules have make
, create
and init
functions. The Array.create
function is deprecated though.
I think the deriving make
ppx is very popular so I'd assume most people use make
. I'm using kubecaml
with Reason where make
seems to be a standard convention.
Well, I’m fine with either. If you want to create a PR switching to deriving make
I’ll accept it.
I'll try to do that when I have time! Thanks!
This PR adds an extra unit after non-optional named arguments.
See issue https://github.com/andrenth/kubecaml/issues/2 for motivation.
This behaviour is consistent with the popular
deriving make
ppx.Another minor thing: would you consider renaming the
create
functionmake
to make it even more consistent? :)