Swap Json.safe with Json.t as it is deprecated for latest release of yojson

andrenth / ocaml-swagger

Swagger 2.0 code generator for OCaml

37 stars 10 forks source link

Closed frejsoya closed 4 years ago

rizo commented 5 years ago

Hi, @frejsoya!

Thanks for this PR, I was planning on submitting something like this too.

I think it makes sense to also constrain the version of the yojson package to "yojson" {>= "1.6.0"}, where the t types were introduced.

I can see that you submitted the last commit (34d2314) as a separate PR. Do you want to remove it from here?

frejsoya commented 5 years ago

Thanks for the feedback @rizo. Fixed the change. Not sure if this project is maintained though 🤷‍♂ :)

rizo commented 4 years ago

Sorry for such a long delay. I'm going to merge this. Ideally we should prepare a release to opam with this change.