Closed rdavison closed 5 years ago
I believe ?ctx
is needed to create a cohttp HTTPS client.
Do you think the async version should have the ?ssl_options
parameter, or is it possible to make HTTPS requests without it in cohttp-async?
Some awesome work here, lots of stuff! Are you still working on it? Would you like me to merge it now or wait a bit more?
Hey! Actually didn't mean to trigger any alerts or anything yet. The code quality and commit messages are a bit.... dubious... since I wasn't really preparing to get it merged any time soon :sweat_smile: .
In any case, it would be nice to eventually get these changes merged, but I'm not in a rush.
A high level overview:
?ssl_options
in yet.
Ref: https://github.com/andrenth/ocaml-swagger/issues/2
One thing I was confused about was the need for the
?ctx
param on the http backed functions. I couldn't tell if there was a parallel feature in cohttp-async, so I removed the optional argument when code-generating the async library.