search

andreogle / eslint-teamcity

A (now deprecated) ESLint formatter plugin for TeamCity. Use eslint-formatter-teamcity instead
MIT License
38 stars 9 forks source link

Formatter has to be used with path #184

Closed Franziskus1988 closed 2 years ago

Franziskus1988 commented 2 years ago

Hey ho.

According to the EsLint docs for formatters you can use formatters in a more generic way when use the following naming scheme: eslint-formatter-$NAME$.

What about renaming this package to eslint-formatter-teamcity, so that it can be used with eslint -f teamcity.

E.g. for those using Yarn's pnp mode this would be beneficial.

What do you think?

andreogle commented 2 years ago

Hey!

Yeah this was actually raised a while ago. I shut down the issue because I didn't want to maintain two separate repos. However, this package doesn't get many updates these days so I'm fine renaming it to conform to the ESLint guidelines and slowly deprecating this one.

I've published it as a new package (under a new repo too). I haven't had a chance to test it out properly yet - I just renamed some things and updated the README - but feel free to give it a try and let me know if you have any issues

Franziskus1988 commented 2 years ago

Cool. Thanks. I will try it out and let you know.

andreogle commented 2 years ago

@Franziskus1988 any issues with the new package?

andreogle commented 2 years ago

Closing this. Feel free to re-open if there are any issues with the new package

Franziskus1988 commented 2 years ago

Thank you! Everything is working fine.

...Sorry for late answer, I was distracted by other stuff.... 😢