search

andreoliwa / nitpick

Enforce the same settings on multiple projects
https://nitpick.readthedocs.io/
MIT License
399 stars 25 forks source link

Nitpick should fail when no style is explicitly configured #491

Closed cbenz closed 1 year ago

cbenz commented 2 years ago

Problem

I installed nitpick in my project, but I forget to configure the style = key in [tool.nitpick], so when I ran nitpick fix it used the default nitpick style which created a package.json, .github/ directory, etc. which I do not need.

Possible solution

I would have expected the tool to fail and tell me to explicitly configure a style.

I'm creating this issue because I do not really see any use case where using the default nitpick style makes sense. If not, I'm curious about that.

andreoliwa commented 2 years ago

Hi, thanks for opening the issue.

I'm creating this issue because I do not really see any use case where using the default nitpick style makes sense. If not, I'm curious about that.

The use case is/was: I use the default style myself. 😅

But you're right, it makes more sense to fail when no style is configured. And then ask the user to run nitpick init to initialise the repo.

github-actions[bot] commented 10 months ago

:tada: This issue has been resolved in version 0.35.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: