feat: using token authorization for styles on Github to be able to us…

andreoliwa / nitpick

Enforce the same settings on multiple projects

https://nitpick.readthedocs.io/

MIT License

393 stars 24 forks source link

Closed danygielow closed 1 year ago

danygielow commented 1 year ago

…e all types of Github tokens

Issues fixed by this pull request: Fix #602

Using Token Authorization instead of Basic Authorization when downloading styles from Github

[X] Read the contribution guidelines
[X] Run make locally before pushing commits
[X] Add tests for the relevant parts:
- [X] API
- [ ] CLI
- [ ] flake8 plugin (normal mode)
- [ ] flake8 plugin (offline mode)
[ ] Write documentation when there's a new API or functionality

andreoliwa commented 1 year ago

Thank you for the PR! I'll try this as soon as I can and get back to you.

andreoliwa commented 1 year ago

@danygielow I have tested your branch with personal access tokens (both classic and beta), and they still work.

I don't have a GitHub App setup to test manually but I trust it works for you.

I'm merging this. Thanks again. 🚀

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 0.34.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: