andreped / super-ml-pets

🐢 AI for Super Auto Pets
MIT License
31 stars 13 forks source link

Lag in the actual game cause the CV system to malfunction #39

Open GoldExplosion opened 2 years ago

GoldExplosion commented 2 years ago

Whenever the game lags, the CV system doesn't realize this and detects the Shop Slots again causing a disruption between the actual game and the engine. Proper detection of lags needed.

GoldExplosion commented 2 years ago

I would like to work on this. I also want to add proper error handling and other possible improvement to CV System. Can I take this issue?

andreped commented 2 years ago

Yeah, thats true. Right now we have a lot of hard coded solutions. It is nice for developing and stuff, but likely will lead to issues for other people. Great if this could be done in a better way.

Sure! Just go ahead :)

andreped commented 1 year ago

@GoldExplosion I was thinking of doing some improvements the framework. Actually trying to make a chrome extension such that people could try it with the web app in a more seemless manner. Mostly just to learn how to make web extensions.

Sadly, as the game has progressed quite a bit since last time I worked on this project, and both the sapai and sapai-gym projects not either been updated, the AI will likely not do well anymore, as the simulated and real environments have diverged.

GoldExplosion commented 1 year ago

That sounds interesting. I want to apologise for not closing this issue ( became busy with irl stuff).

I want to contribute to this web extension if possible.

andreped commented 1 year ago

That sounds interesting. I want to apologise for not closing this issue ( became busy with irl stuff).

No worries! I have been awfully busy myself. Just now that I had some time off to do other things.

I want to contribute to this web extension if possible.

I just made an Issue about it: https://github.com/andreped/super-ml-pets/issues/46. We could take the discussion there or in the Discussions tab.

Another key feature I want to add is to be able to run unit tests for deployment (see issue https://github.com/andreped/super-ml-pets/issues/49). I was hoping of boosting the code coverage from 21% closer to 100%. You could contribute there as well if you'd like. Up to you :]