search

andreped / super-ml-pets

🐢 AI for Super Auto Pets
MIT License
31 stars 13 forks source link

SAP's UI and animals have updated - machine vision system needs updating #55

Closed andreped closed 1 year ago

andreped commented 1 year ago

Switching to classical style partly resolves this issue as mentioned in https://github.com/andreped/super-ml-pets/issues/52#issuecomment-1500241721.

This uses the old style of the animals. However, the UI might still be slightly different.

laughinggaschambers commented 1 year ago

I'm having issues getting it to see anything, might be related but switching between classic and standard doesn't help a bit. This was a fresh install. Windows 10. image

Edit: nvm, I just found the classic skin for the animals. But its now it's numpy errors image

andreped commented 1 year ago

Hello, @laughinggaschambers! :]

I'm having issues getting it to see anything, might be related but switching between classic and standard doesn't help a bit. This was a fresh install. Windows 10.

This is a exactly the same as observed in issue https://github.com/andreped/super-ml-pets/issues/52.

Basically, all pets' icons needs updating, AFAIK. However, both you and @Potajito actually find pets on the windows version, whereas I had issues from the web app. Might be that this is easier to solve than I first anticipated, and that reverting to the old style actually resolves the icon issue. But that means that there is another cause for this issue.

laughinggaschambers commented 1 year ago

Did a little poking around the code, a dirty quick fix is to add action = int(action) in deploy_agent.py at line 125 it runs then.

andreped commented 1 year ago

Did a little poking around the code, a dirty quick fix is to add action = int(action) in deploy_agent.py at line 125 it runs then.

Oh, that's surprising. But great! Perhaps there is a versioning issue with numpy, stable-baseline3, or similar.

Could you make a PR with this fix and I could run some tests and review it?

andreped commented 1 year ago

I saw you made a PR. Great!

I made a comment which it would be great if you addressed before merging, see https://github.com/andreped/super-ml-pets/pull/56

andreped commented 1 year ago

Fixed in https://github.com/andreped/super-ml-pets/pull/56.

I also added the additional step of changing the UI style in the deployment instructions in be6857123bce5b52d926adb38e7f44b6da6823f1.

andreped commented 1 year ago

Just tested this now on my windows laptop at home, and it does indeed work. However, I came across another issue, related to event regarding health after a game, see issue https://github.com/andreped/super-ml-pets/issues/57.