search

andrepl / SalvageSmelter

Bukkit plugin to allow smelting armor and tools to raw materials.
3 stars 7 forks source link

Items without a damage value always return coal. #6

Closed SeeJayEmm closed 11 years ago

SeeJayEmm commented 11 years ago

I'd like to be able to add recipes for items that do not have a damage value (for example iron bars, iron doors, rails, etc...) Unfortunately since they do not have a damage value coal is always returned.

22:34:36 [INFO] [SalvageSmelter] SmeltEvent::Source: ItemStack{RAILS x 1} 22:34:36 [INFO] [SalvageSmelter] SmeltEvent::Damage:ItemStack{RAILS x 1} 22:34:36 [INFO] [SalvageSmelter] getSalvage(RAILS, IRON_INGOT, NaN) 22:34:36 [INFO] [SalvageSmelter] getSalvage::Mathification:5 * NaN = 0

I realize I could "set always-yield-full-amount: true" to bypass this issue but that's not ideal and is ripe for abuse.

Thanks

andrepl commented 11 years ago

The only way I could like this ticket more is if you included the code to implement it :)
Thanks for including the debug output, makes this very simple. I'm going to add the feature right now and get a development build out, but it's late so I probably wont be able to test it tonight.

andrepl commented 11 years ago

you can grab the development build here: http://mcgitlab.norcode.com:8081/job/SalvageSmelter/lastStableBuild/ It should simply treat any non-damageable items as 100% durability. totally untested but probably fine :) If you try it please post your results here.

andrepl commented 11 years ago

This was fixed in 0.1.4