search

andrepolischuk / keep

Desktop app for Google Keep packaged with Electron
The Unlicense
411 stars 70 forks source link

Feature Request: Black Theme #38

Closed lukassr closed 5 years ago

lukassr commented 5 years ago

It would be awesome if there was a option to activate a black theme, similar to the chrome extension makes with the Keep webview: Darkreader:

screen shot 2019-01-28 at 1 25 49 pm

Reading the code of Darkreader, the customization have static and dynamic changes, so adding CSS style rules is not enough. I tried to import the extension to Electron and build it, but Electron don't have support for custom extensions yet, and they don't have future plans for it.

Very nice app! It doesn't take a lot of resources like other versions found.

lukassr commented 5 years ago

I created a separate app with dark theme: https://github.com/lukassr/keep-dark-desktop. Used this repo and a dark theme from https://userstyles.org/. Thanks for the contribution and the unlicense license.

andrepolischuk commented 5 years ago

@lukassr why not pull request?

lukassr commented 5 years ago

Since it's my first work with electron, I downloaded the repo to play around, so I know there are bad practices and bad code. Also, it would overwrite the original template, that's why I preferred to have it as a separate repo. If I have time to learn how to make a menu with an option to choose the theme, I will send an PR 🙂

andrepolischuk commented 5 years ago

it would be great