Fix issue with goal_type being mapped to note for categories when using the budget detail endpoint

andreroggeri / ynab-sdk-python

Python implementation of the YNAB API (https://api.youneedabudget.com/)

Apache License 2.0

27 stars 10 forks source link

Closed birdwing closed 2 years ago

birdwing commented 2 years ago

This is a fix for issue #102

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit abf66ba3 and detected 0 issues on this pull request.

View more on Code Climate.

andreroggeri commented 2 years ago

Thanks !

birdwing commented 2 years ago

No worries. I loaded this up as my own package into home assistant. And it is still pulling the note in "goal_type"

Is there anywhere else that this mapping could be wrong? It could just be an issue with cacheing.

andreroggeri commented 2 years ago

Its been some time that I dont contribute to this package.

From what I looked up this change is correct.

I'll merge and generate a new version so you can check it again

andreroggeri commented 2 years ago

0.3.0 is released on pypi.

Can you please check ?

birdwing commented 2 years ago

Yes that did it! Thank you.