andreruffert / rangeslider.js

🎚 HTML5 input range slider element jQuery polyfill
https://rangeslider.js.org
MIT License
2.16k stars 401 forks source link

Fails to init if polyfill: false is not specified #177

Closed aiaf closed 8 years ago

aiaf commented 9 years ago

Must be initialized with at least

{ polyfill: false }

for this to work (Chrome 45, Firefox 40). If you supply no arguments to .rangeslider() it fails silently. This should be documented somewhere.

Chrisriis commented 9 years ago

I can confirm this issue. Used some time to debug it because there's no error returned as mentioned.

brianO3world commented 9 years ago

Confirmed this is an issue as well

andreruffert commented 9 years ago

Hey guys :)

rangeslider.js is developed to be a polyfill for the <input type="range>" element. Which means if the browser has no support for the element rangeslider.js provides the functionality you expect. But of course you could also use it in browsers which support the <input type="range>" element by setting { polyfill: false }.

I hope this makes it a bit more clear for you. If you think it's confusing to understand and have a suggestion to make it better to understand in the docs feel free to make a pr for that or just comment right here.

:v:

andreruffert commented 8 years ago

Closing because of no feedback...

brianO3world commented 8 years ago

Apologies, I just saw this again. The clarification you provided above was perfect. For me, I think the issue is more making that clear in the usage notes. I specifically needed a custom styled rangeslider, but since I was using a browser that supported it, nothing was rendering.

More a point of documentation than it being incorrect. Sorry for the confusion. And thanks for taking the time to review this!