search

andres-montanez / Magallanes

The PHP Deployment Tool
https://magephp.com
MIT License
691 stars 169 forks source link

Update require-dev phpunit to 5.x #345

Closed mbaeuerle closed 7 years ago

mbaeuerle commented 7 years ago

Is there a specific reason why phpunit 4.8.x is used? Version 5 adds quite nice features like:

$this->expectException(ErrorException::class);
$this->expectExceptionMessage('Parameter "file" is not defined');
andres-montanez commented 7 years ago

Yes, PHPUnit 5 and above require PHP 5.6, and changing that will break compatibility with Symfony 3 which requires PHP 5.5.9.

End of the year Symfony 4 will be released with a PHP requirement of >= 7 ;)

mbaeuerle commented 7 years ago

Symfony achieved php 7 compatability 2 years ago! PHP 5.5.9 is the minimum required version, so it should be fine to upgrade!

andres-montanez commented 7 years ago

Yes, but the require is still in the dependencies, so you can run Symfony3 with php 5.5.9+, that should be maintained here in order to allow those users to use Magallanes.

mbaeuerle commented 7 years ago

Ah okay, so the issue is not Symfony but the version of php. So you want to maintain php 5.5.9 as the minimum requirement for Magallanes as long as possible?

But then it's just a require-dev to change. And I think you can expect the Magallanes contributers to use a newer version of php than 5.5

andres-montanez commented 7 years ago

Exactly, I want to maintain the same minimum requirements as Symfony3. And I hope most of those who uses Magallanes have newer versions, I still want to maintain the most compatibility, that's also why Travists tests are run against 5.5, 5.6, 7.0 and 7.1 ;)

mbaeuerle commented 7 years ago

Okay alright then I close this for now.