search

andres-montanez / Magallanes

The PHP Deployment Tool
https://magephp.com
MIT License
691 stars 169 forks source link

Feature/abstract strategy #370

Closed yamilovs closed 7 years ago

yamilovs commented 7 years ago

Just reformat code for working with abstract class, instead of code duplicate.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 99.895% when pulling dd6490e95f2eb759f5f6e9fb74322cdf4031ceb6 on yamilovs:feature/AbstractStrategy into 1ebe6c4ba73cda2b3a34acf801f8b2770283cbeb on andres-montanez:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 99.895% when pulling dd6490e95f2eb759f5f6e9fb74322cdf4031ceb6 on yamilovs:feature/AbstractStrategy into 1ebe6c4ba73cda2b3a34acf801f8b2770283cbeb on andres-montanez:master.

yamilovs commented 7 years ago

Decreasing of code coverage can not depend on my commits because abstract class do the same things as it was.

andres-montanez commented 7 years ago

Hi, thanks for the PR, but the changes on the deploy strategy will be handled further in the road map, now is too soon.

Thanks!