search

andres-montanez / Magallanes

The PHP Deployment Tool
https://magephp.com
MIT License
691 stars 169 forks source link

Allow symlink name parameter #371

Closed duraki closed 7 years ago

duraki commented 7 years ago

From what I can see in Mage v3, we lost a way to hardcode a symlink directory thus the deployment creates appropriate releases and current, breaking all old Docker images:

When using Releases you have to take into account that Magallanes will create a releases directory in the host_path directory, and a symbolic link current which will point to a release inside releases.

In Mage v1, we had a following option:

releases:
    enabled: true
    max: 5
    symlink: whatever-the-fuck-symlink-i-want
    directory: releases

Any chance to get this back? And is there a reason why it's not enabled by default?

andres-montanez commented 7 years ago

Hi, currently there is no roadmap for adding this feature back. Magallanes v3 main goal is code quality and stability, then we can add these cosmetic features.

Regards!

duraki commented 7 years ago

I can't figure out how would this break the code quality and stability in any matter? It's just another parameter in environment config. Whatsoever, it can only bring an advantage to have something like this as initially.

andres-montanez commented 7 years ago

@dn5 this means a new config variable, a new option to propagate through the tasks, new test cases, etc. I hope you see my point.

Regards.