[bugfix] Update config for Travis CI in order to run tests in a containerized Trusty environment with PHP 7.2 and lowest dependencies on PHP 7.1

andres-montanez / Magallanes

The PHP Deployment Tool

https://magephp.com

MIT License

691 stars 169 forks source link

[bugfix] Update config for Travis CI in order to run tests in a containerized Trusty environment with PHP 7.2 and lowest dependencies on PHP 7.1 #417

Closed phansys closed 6 years ago

phansys commented 6 years ago

Q	A
Branch	master
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

PSR-3 compatibility was added in monolog/monolog:1.23.0;
Bumped to symfony/yaml:3.0.7 in order to avoid errors like Mage\Runtime\Exception\RuntimeException: Error parsing the file "/home/travis/build/andres-montanez/Magallanes/tests/Command/BuiltIn/../../Resources/testhost.yml".

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling 3d04419884a96a005a76cce14743f8a147bc0cb2 on phansys:travis into b13b3f92b6642414e5d432f7fa3a7c51b3966826 on andres-montanez:nostromo.

andres-montanez commented 6 years ago

Will be solved in 3.4 Cheers

phansys commented 6 years ago

What this means @andres-montanez? Which branch is meant to be used as target for 3.4?

andres-montanez commented 6 years ago

The branch nostromo is the current development branch, which will be the base for release 3.4

phansys commented 6 years ago

So, why you're closing this PR? It's targeting nostromo.

andres-montanez commented 6 years ago

I've already pushed a patch, so no need for the PR. Thanks!

phansys commented 6 years ago

Well, I see just one addition coming from this PR in b5f181bb18c81e7581a59ac36405eb988a6b7e25, but I don't see anything there about the dependency fixes introduced here. What about that? Same for lowest version tests.

phansys commented 6 years ago

@andres-montanez, is this project open to accept PRs for the concerns I've exposed, or do you have different plans?