Use fallback for posix_getpwuid on Windows

[fritzmg]

With one other adjustment (see https://github.com/andres-montanez/Magallanes/issues/306#issuecomment-419921293) Magallanes seems to work without an issue under Windows, at least under the Windows Git Bash.

The only change I had to make in the source of Magallanes is to provide this fallback for posix_getpwuid, which is of course not present on the Windows platform.

[coveralls]

Coverage decreased (-0.1%) to 99.887% when pulling df248dd1b00f759e017793c0b576e97f5e024afe on fritzmg:patch-1 into e30de6b719c923d70917a9f9364efdb29b7e9362 on andres-montanez:master.

[t-fritsch]

any chance this PR would be merged ?

[fritzmg]

@tfritsch-km the project does not seem to be maintained anymore. Also I should still change the tests, so that this change is covered.

[fritzmg]

@tfritsch-km my fork now contains a branch that includes all windows fixes so far: https://github.com/fritzmg/Magallanes/tree/windows-fixes

You could add that as a repository in your global composer.json and then require "andres-montanez/magallanes": "dev-windows-fixes".

{
    "require": {
        "andres-montanez/magallanes": "dev-windows-fixes"
    },
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/fritzmg/Magallanes"
        }
    ]
}

[iannacone]

the alternatives are:

• exec('whoami') which i totally do not recommend for the high permissions requirement
• make the getEnvOption 2nd argument lazy loaded (that value is not always really needed), but this change requires some work

btw i honestly do not understand why the coverage decrease of the 0.1%. imo under windows it throws an exception which means as now it is not cover 100% all the cases. could you please be so gentle and explicit share what cases do not meet the requirements?

[andres-montanez]

Hi @iannacone , the coverage decreases because there is no test entering inside the if added for the feature. Magallanes has never been too kind with windows, however, I will take a look at this in the next weeks to improve compatibility.

Take care!

[andres-montanez]

Thanks @fritzmg , this improvement will be available on v5!