search

andres-montanez / Magallanes

The PHP Deployment Tool
https://magephp.com
MIT License
691 stars 169 forks source link

fix tar_create command on Windows #434

Closed fritzmg closed 3 years ago

fritzmg commented 5 years ago

Under Windows, we need the --force-local argument for tar_create by default. Otherwise, due to the : in absolute Windows file paths, tar thinks that the path is on another machine - and you have to override this using --force-local (see also https://github.com/Microsoft/azure-pipelines-tool-lib/issues/34 for example).

Imho it is important to integrate this into Magallanes, so that a .mage.yml can be committed to a git repository and then used by Linux and Windows users alike. Otherwise if you put

tar_create: --force-local -c -z -p -f

into your .mage.yml it will not work for *nix users anymore - and without it it won't work for Windows users.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.1%) to 99.886% when pulling 94eeb9cb9d7a79a7200fa7cc490b33de8081c1ea on fritzmg:fix-windows-tar-args into e30de6b719c923d70917a9f9364efdb29b7e9362 on andres-montanez:master.

andres-montanez commented 3 years ago

Hi @fritzmg , thank you very much for your time and effort, and thinking about the compatibility issues. I will merge this PR and release it soon. Thank you again!