search

andres-montanez / Magallanes

The PHP Deployment Tool
https://magephp.com
MIT License
694 stars 167 forks source link

Make CopyTask scp command timeout configurable #436

Closed artur-tud closed 3 years ago

artur-tud commented 5 years ago

Use case: Deploying using releases will copy the tar archive to the remote server with "scp command" with a timeout maximum of 300 seconds .

Problem: If you have limited upload bandwidth and/or big tar archives, the command will run into a timeout after 300 seconds. $process = $this->runtime->runLocalCommand($cmdCopy, 300);

Solution: Make the timeout for the CopyTask (scp upload command) configurable in the .mage.yml file. The default value can still be 300 seconds.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ddc3825e76a8d2fb06457059641c424e673c2c65 on artur-tud:feature/release-with-timeout into e30de6b719c923d70917a9f9364efdb29b7e9362 on andres-montanez:master.

andres-montanez commented 5 years ago

Thanks man, I will review it when I'm able, probably port it to v3 too. Regards.

nntoan commented 4 years ago

Hi @andres-montanez , any updates on this? It would be very useful especially in case having trouble with ISP which slow down your internet speed.

andres-montanez commented 3 years ago

Thanks everyone for their time and effort! I will be releasing this soon.