andresdominguez / elementor

An improved element finder for protractor
MIT License
339 stars 27 forks source link

Does not work with latest version of Chrome #58

Open mrj04 opened 7 years ago

mrj04 commented 7 years ago

Version 59.0.3071.115 URL does not get opened when issued the command elementor url explicitly when we navigate to the desired URL the locators does not found. it says finding "Cannot find suggestions" "Finding suggestions" does not load any suggestions.

nadimsaker commented 7 years ago

Same happens on my side. Can anybody help me?

bradleymize commented 6 years ago

I got it working with the following versions of protractor, elementor, and webdriver-manager installed globally running chrome version (61.0.3163.91) :

$ which protractor
/home/user/.nvm/versions/node/v6.11.3/bin/protractor

$ protractor --version
Version 5.1.2

$ which elementor
/home/user/.nvm/versions/node/v6.11.3/bin/elementor

$ elementor --version
2.1.0

$ which webdriver-manager
/home/user/.nvm/versions/node/v6.11.3/bin/webdriver-manager

$ webdriver-manager version
I/version - webdriver-manager 12.0.6

Verified that it was grabbing (at least) chromedriver_2.32.zip with webdriver-manager update:

[21:52:45] I/update - chromedriver: file exists /home/user/.nvm/versions/node/v6.11.3/lib/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_2.32.zip
[21:52:45] I/update - chromedriver: unzipping chromedriver_2.32.zip
[21:52:45] I/update - chromedriver: setting permissions to 0755 for /home/user/.nvm/versions/node/v6.11.3/lib/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_2.32
[21:52:45] I/update - chromedriver: chromedriver_2.32 up to date

Afterwards, I was able to do webdriver-manager start and elementor www.google.com successfully.

I found out I just needed to update chrome by modifying the following in elementor/lib/spawnHelper.js:

//line 36:
child.stderr.on('data', process.stderr.write);

//became
child.stderr.on('data', function(data) {
  console.log("child error:", data);
  process.stderr.write(data);
});

With the addition of the console log, I saw the actual error that, for whatever reason, wasn't written to process.stderr (was getting a generic throw err error), that informed me I needed to upgrade to at least chrome 59.x.x.x.

adityagautam commented 6 years ago

Downgrade your node to 6.9.5. That should do the trick.

stefangrotz commented 6 years ago

Thanks. It would be great if elementor could work with the latest LTS version of Node (atm 8.10) This would help a lot of people, because a lot of teams migrate from LTS to LTS version