Update info_about_os.sh

andresgongora / synth-shell-greeter

A system status report and your personal ASCII-art logo for your terminal sessions

GNU General Public License v3.0

13 stars 15 forks source link

Update info_about_os.sh #39

Closed AbhiTheModder closed 5 months ago

AbhiTheModder commented 5 months ago

When we're getting Kernel info already through -r then doesn't it looks ugly to see the same thing and weird long line in OS name :)
Looks ugly to see path to shell the current shell, for ex. if we're on Termux (Android) it shows lengthy line like /data/data/com.termux/files/user/bin/bash

andresgongora commented 5 months ago

Hi, thanks for you contribution!! I can't accept this one as is quite yet. Would it be OK if I add support for it through other means? My rationale is:

uname -o looses important information about kernel and distro versions
$(basename "$SHELL") looks neater, I agree with you. Still, I suspect most sysadmins need to some extent info about the exact terminal emulator they are running. If you are OK I can revamp your commit to create a new pair of options

andresgongora commented 5 months ago

Ahh OK I see what's going on wiht os_name=$(uname -o), there is indeed another line to get the kernel info, so it would be reduntant. You are right!!

andresgongora commented 5 months ago

Ok! I've incorporated $(basename "$SHELL") into synth-shell-greeter and created a separate option to retain the full shell dir for those who need it. Kindly remove that bit from your pull request and then we can merge the part with uname -o

AbhiTheModder commented 5 months ago

  If you are OK I can revamp your commit to create a new pair of options

Yeah, That is also a nice idea, thanks for this and your work ❤️

andresgongora commented 5 months ago

Thanks for your contribution!! :) I think you also had an open PR to add your user's config. Feel free to reopen it if you want