search

andreskull / rFTX

R API for FTX
Other
5 stars 12 forks source link

Adding ftx init #23

Closed PaulineNimo closed 2 years ago

PaulineNimo commented 2 years ago

I have added a function that sets the base url on load. There is another function that also resets the value of the url, from .com to .us based on user input. If you do not mind suggesting ways to have the user know how to change the default .com url value to .us, it will be appreciated. Currently, upon loading of the package, there is a loginfo message indicating the instructions. R CMD check succeeded but it may not be very neat.

andreskull commented 2 years ago

Nice solution, I like it, but .....

It does not work in a fully automated use case, where you would like to start right away with ftx.us. I would keep just one function ftx_init() with an optional parameter url. If urlis given then it is set as a base_url. Otherwise, the dialog is started as in ftx_init_reset()currently. At loading time it is ok to load ftx.com as now. This is user's responsibility to call ftx_init('ftx.us') in the automated use case before other ftx calls.

PaulineNimo commented 2 years ago

Okay, that makes a lot of sense. I will rework this.