search

andresmrm / EtherPlant

A simple web page to code in Etherpad and visualize in PlantUML.
GNU Affero General Public License v3.0
2 stars 4 forks source link

My version of your cool tool #3

Open matthieusalvat opened 8 years ago

matthieusalvat commented 8 years ago

Hi Andrés,

You can find my fork of your project here : https://github.com/Orange-OpenSource/EtherPlant

I do this fork to improve the ergonomy. Now we can zoom and navigate on the diagram. I also add a menu bar. I have also change the deflate lib to use a more simple implementation.

Regards.

Matthieu

andresmrm commented 8 years ago

Salut Matthieu,

Nice rewrite! Much more user friendly!

But I noticed you deleted the bookmarklet... Any special reason for that? Not sure, but maybe it was useful for some people... Maybe we could keep a link for it somewhere?

I'm also missing, in your version, the warnings that were in my index.html. What's your opinion about that? Should we move them to the README.md?

With those changes I would be glad to merge your PR. But I saw you changed most of the links to point to your repository. Do you plan to keep maintaining it? If so, maybe, instead of merging, I should point to your repository as the new "oficial" one. What do you think? And maybe you should even talk to planuml.com to change the link in this list: http://plantuml.com/running.html But if you're not sure about maintaning your version, maybe it would be simpler just to accept your PR. =)

matthieusalvat commented 8 years ago

For the bookmarklet is just because I don't know how it works !

For warnings, i must change the README.md and copy a part in the .not-working class when EtherPlant it launch without pad URL.

I will maintain my repository as long as possible. I also prepare a new tools based on the same basis as EtherPlant : https://github.com/Orange-OpenSource/EtheRemark (first push coming soon).

For the PR I just do it to inform you of my fork :).

andresmrm commented 8 years ago

For the bookmarklet is just because I don't know how it works !

I'm also not used to bookmarklets. I did this because of a friend's request. To use:

  1. Go to the index page: http://andresmrm.github.io/EtherPlant/src/etherplant.html
  2. Check the "Bookmarklet" section and drag the "EtherPlant" link there to your bookmarks (it should create a button).
  3. Go to a pad using HTTP (not HTTPS), like this: http://piratepad.be
  4. Code your PlantUML and press the button you created in your bookmarks in step 2.

It should run the JS code in the bookmarklet and open a PlantUML viewer.

The main advantage of this method is not to require the TXT exportation of the pad content from the server every X seconds (what was criticized by JohnMcLear). The bookmarklet, because it runs directly on the current page and not in a different iframe, has direct access to the pad content in the page (no need to request it from server).

I will maintain my repository as long as possible. I also prepare a new tools based on the same basis as EtherPlant : https://github.com/Orange-OpenSource/EtheRemark (first push coming soon).

Cool! =D

For the PR I just do it to inform you of my fork :).

Ok, so I guess I'll keep this repository this way, and just add a link to your version.

andresmrm commented 8 years ago

Done! Placed references to your version in the index.html and readme. =)