search

andresz1 / size-limit-action

Compare the real cost to run your JS app or lib to keep good performance in every pull request
ISC License
449 stars 83 forks source link

feat: Use GitHub artifacts for main branch runs #37

Closed billyvg closed 3 years ago

billyvg commented 4 years ago

This is a bigger change that:

1) Uses GitHub Artifacts to save size-limit json results for main branch runs. 2) Removes the need for PRs to run builds twice (one for branch and one for main branch) 3) Supports results when base fails to fetch 4) Adds input for different main branch (default is master)

Closes #33 Closes #30

billyvg commented 4 years ago

cc @andresz1

andresz1 commented 4 years ago

Hi @billyvg, wow! thank you so much for this PR, nice usage of GitHub Artifacts 🎉 I have some questions about the changes:

Regards!

billyvg commented 4 years ago

Hi @billyvg, wow! thank you so much for this PR, nice usage of GitHub Artifacts 🎉 I have some questions about the changes:

  • Will it only work against master ?

Nope, it takes in input for the main branch

  • What if Artifacts usage is enabled by an action input and not enabled by default. What do you think ?

This won't be something that I'll add, but feel free to use the contents of this PR as you like