search

andresz1 / size-limit-action

Compare the real cost to run your JS app or lib to keep good performance in every pull request
ISC License
451 stars 84 forks source link

Should % changed be compared against base instead of current? #41

Closed billyvg closed 4 years ago

billyvg commented 4 years ago

https://github.com/andresz1/size-limit-action/blob/master/src/SizeLimit.ts#L48

Wouldn't this make more sense to compare against base instead of current?

    const value = ((current - base) / base) * 100;

If base is 100, and current is 200, then base increased by 100%.

andresz1 commented 4 years ago

Yes! I think that you are right @billyvg thank you so much!