andresz1 / size-limit-action

Compare the real cost to run your JS app or lib to keep good performance in every pull request

ISC License

451 stars 84 forks source link

Closed nwaughachukwuma closed 2 years ago

nwaughachukwuma commented 2 years ago

/opt/hostedtoolcache/node/16.13.1/x64/bin/npm install npm ERR! Cannot read properties of null (reading 'matches')

Going by the logic shown below, this size-limt-action doesn't support projects running with pnpm, and throws the error highlighted above:

 const manager = hasYarn(directory) ? "yarn" : "npm";

Is there a special need required to support pnpm? I can PR a fix.

nwaughachukwuma commented 2 years ago

71

nwaughachukwuma commented 2 years ago

Fix has been merged. Closing...