Open Soviut opened 2 years ago
I just ran into this as well. It looks like the install step that is running is the (even with the skip_install
flag set) is for the size comparison between the PR and the base branch. The skip_install
flag is not being passed to this size-limit execution: https://github.com/andresz1/size-limit-action/blob/1f3a2e486e49bf37642e97ab4df412cec1febf97/src/main.ts#L65
I assume this is intentional because it needs to install the dependencies as they exist on the base branch to properly compare the size-limit results.
Seems like #82 would be a good solution for flexibility and different use cases but I wonder if simply using npm ci
instead of npm install
would work for standard use cases 🤔
I am still having this issue, it skipped install once and now it doesn't do it anymore.
Same here, already installed deps in our job so don't need this auto install - skip_step: build
should prevent both install and build but both occur and then runs npx size-limit --json
again...
I'm trying to skip the install step so that I can install manually. I need to install manually so I can use some install flags to ignore peer dependency warnings in npm 8 which halts the build.
.github/workflows/size-limit.yml
The build logs look like this (slightly truncated and anonymized)