get_fix timeout does not work

andrethemac / L76GLNSV4

MicroPython library for quectel L76 glnss gps on pycom pytrack

MIT License

18 stars 16 forks source link

get_fix timeout does not work #13

Closed vinci1it2000 closed 2 years ago

vinci1it2000 commented 4 years ago

The timeout does not work, because the chrono is continuously reset inside the while loop by _read_message.

https://github.com/andrethemac/L76GLNSV4/blob/1cf479b88adf98767afd8459de1f33afcf6fa7ca/L76GNSV4.py#L323

dgraposo commented 4 years ago

The same behaviour here! Thanks for the project! Great contribution!

andrethemac commented 4 years ago

New commit by Patrick should fix the error. Can you try again?

kbondarev commented 4 years ago

I have stumbled on the same issue.

I think in order to fix this you need to create different chrono instances in each function instead of having one instance of chrono in the whole class (self.chrono)

I can attempt and fix this and create a pull request if you want

andrethemac commented 2 years ago

Hi everybody. Thank you for the fixed. best regards