search

andreusxcarvalho / pe

0 stars 0 forks source link

delete normal entry works in situations where it should not #1

Open andreusxcarvalho opened 1 week ago

andreusxcarvalho commented 1 week ago

Expected: Please use the correct format : delete INDEX Actual: Command still goes through despite extra text entered after index

For some reason, if the user enters the flag wrongly (/r or /recurring instead of /recur), the app goes ahead and delete the NORMAL entry, when the user intended to delete the recurring one. So it would be good to handle the edge case for when the flag is misspelled. Screenshot 2024-11-15 at 4.41.10 PM.png

soc-pe-bot commented 4 days ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

This outcome is intended.

image.png

Because the incorrect "recurring" flag was used, the program registers the command as a command for normal expenses. So the execution of the command still proceeded correctly.

While it is reasonable to have handlings for flag misspellings, it would be infeasible implementation-wise (because there are many ways the user can make a mistake). Therefore, even if this is a needed feature, it would fall under NotInScope anyway.

This is also in line with other command line interfaces: https://github.com/AY2425S1-CS2113-W12-3/tp/issues/167

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your reason]