search

andreusxcarvalho / pe

0 stars 0 forks source link

Lack of Activation bars in sequence diagrams #6

Open andreusxcarvalho opened 1 week ago

andreusxcarvalho commented 1 week ago

Screenshot 2024-11-15 at 5.27.44 PM.png

nus-se-bot commented 1 week ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

The severity of this should be very low, as the lack of activation bars in sequence diagrams is a purely cosmetic flaw and does not affect the usage of the program

Moreover, the CS2113 website states that activation bars can be omitted.

image.png

As stated in the DG screenshot you posted, this class primarily delegates its functionality by calling methods from other category classes. The purpose of the sequence diagram still conveys which category classes CategoryFacade calls for each of its key methods. More precise details like activation bars are not required to convey this idea.

Thus, this is not a bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]